[clang] [analyzer] Add an option to support unity-builds in CSA (PR #242339)
Arseniy Zaostrovnykh via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 13 07:53:47 PST 2026
================
@@ -3297,18 +3297,21 @@ BugReporter::generateDiagnosticForConsumerMap(
static PathDiagnosticCallPiece *
getFirstStackedCallToHeaderFile(PathDiagnosticCallPiece *CP,
- const SourceManager &SMgr) {
+ const SourceManager &SMgr,
+ ArrayRef<StringRef> UnityBuildFileExtensions) {
----------------
necto wrote:
I am not so sure. `AnalysisManager` is very generic and overarching, while `UnityBuildFileExtensions` is narrowly scoped and gives an idea what it is passed for. I would agree if there were too many arguments passed individually, grouping them would make sense to avoid unreadable function signatures and calls, but with 3 parameters, I think it is better to keep them as narrow as practical.
https://github.com/llvm/llvm-project/pull/242339
More information about the cfe-commits
mailing list