[clang] [llvm] [mlir] [IR] Introduce `threadid` memory location (PR #241334)

via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 11 16:51:26 PST 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,cl,h,c -- clang/test/CodeGen/sanitize-metadata-nosanitize.c clang/test/CodeGenCXX/threadlocal_address.cpp clang/test/CodeGenOpenCL/convergent.cl llvm/include/llvm/AsmParser/LLToken.h llvm/include/llvm/Support/ModRef.h llvm/lib/AsmParser/LLLexer.cpp llvm/lib/AsmParser/LLParser.cpp llvm/lib/Bitcode/Reader/BitcodeReader.cpp llvm/lib/Bitcode/Writer/BitcodeWriter.cpp llvm/lib/IR/Attributes.cpp llvm/lib/Support/ModRef.cpp llvm/unittests/Support/ModRefTest.cpp llvm/utils/TableGen/Basic/RuntimeLibcallsEmitter.cpp mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp mlir/lib/Target/LLVMIR/ModuleImport.cpp mlir/lib/Target/LLVMIR/ModuleTranslation.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/unittests/Support/ModRefTest.cpp b/llvm/unittests/Support/ModRefTest.cpp
index a03d1c22c..71a8d8ad0 100644
--- a/llvm/unittests/Support/ModRefTest.cpp
+++ b/llvm/unittests/Support/ModRefTest.cpp
@@ -19,28 +19,28 @@ namespace {
 TEST(ModRefTest, PrintMemoryEffects) {
   std::string S;
   raw_string_ostream OS(S);
-  OS << MemoryEffects::none();
-  EXPECT_EQ(S, "ArgMem: NoModRef, InaccessibleMem: NoModRef, ErrnoMem: "
-               "NoModRef, Other: NoModRef, ThreadIdMem: NoModRef, TargetMem0: "
-               "NoModRef, TargetMem1: NoModRef");
-}
-
-TEST(ModRefTest, ThreadIdMem) {
-  MemoryEffects ME = MemoryEffects::threadIdMemOnly(ModRefInfo::Ref);
-  EXPECT_EQ(ME.getModRef(IRMemLocation::ThreadIdMem), ModRefInfo::Ref);
-  EXPECT_EQ(ME.getModRef(IRMemLocation::Other), ModRefInfo::NoModRef);
-  EXPECT_EQ(ME.getModRef(IRMemLocation::TargetMem0), ModRefInfo::NoModRef);
-  EXPECT_EQ(ME.getModRef(IRMemLocation::TargetMem1), ModRefInfo::NoModRef);
-  EXPECT_TRUE(ME.onlyReadsMemory());
-  EXPECT_FALSE(ME.onlyAccessesInaccessibleMem());
-
-  EXPECT_EQ(MemoryEffects::readOnly().getModRef(IRMemLocation::ThreadIdMem),
-            ModRefInfo::Ref);
-  EXPECT_EQ(MemoryEffects::argMemOnly().getModRef(IRMemLocation::ThreadIdMem),
-            ModRefInfo::NoModRef);
-  EXPECT_EQ(MemoryEffects::inaccessibleMemOnly().getModRef(
-                IRMemLocation::ThreadIdMem),
-            ModRefInfo::NoModRef);
-}
-
+  OS << MemoryEffects::none();
+  EXPECT_EQ(S, "ArgMem: NoModRef, InaccessibleMem: NoModRef, ErrnoMem: "
+               "NoModRef, Other: NoModRef, ThreadIdMem: NoModRef, TargetMem0: "
+               "NoModRef, TargetMem1: NoModRef");
+}
+
+TEST(ModRefTest, ThreadIdMem) {
+  MemoryEffects ME = MemoryEffects::threadIdMemOnly(ModRefInfo::Ref);
+  EXPECT_EQ(ME.getModRef(IRMemLocation::ThreadIdMem), ModRefInfo::Ref);
+  EXPECT_EQ(ME.getModRef(IRMemLocation::Other), ModRefInfo::NoModRef);
+  EXPECT_EQ(ME.getModRef(IRMemLocation::TargetMem0), ModRefInfo::NoModRef);
+  EXPECT_EQ(ME.getModRef(IRMemLocation::TargetMem1), ModRefInfo::NoModRef);
+  EXPECT_TRUE(ME.onlyReadsMemory());
+  EXPECT_FALSE(ME.onlyAccessesInaccessibleMem());
+
+  EXPECT_EQ(MemoryEffects::readOnly().getModRef(IRMemLocation::ThreadIdMem),
+            ModRefInfo::Ref);
+  EXPECT_EQ(MemoryEffects::argMemOnly().getModRef(IRMemLocation::ThreadIdMem),
+            ModRefInfo::NoModRef);
+  EXPECT_EQ(MemoryEffects::inaccessibleMemOnly().getModRef(
+                IRMemLocation::ThreadIdMem),
+            ModRefInfo::NoModRef);
+}
+
 } // namespace

``````````

</details>


https://github.com/llvm/llvm-project/pull/241334


More information about the cfe-commits mailing list