[clang] [llvm] [clang] Fix encoding handling of asm strings (PR #169803)

Hubert Tong via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 10 22:02:32 PST 2026


================
@@ -0,0 +1,17 @@
+// REQUIRES: icu || iconv
+// RUN: %clang_cc1 -triple s390x-none-zos -fexec-charset Shift_JIS %s -std=c++23 -fsyntax-only -verify
+
+struct string_view {
+  const char *D;
+  int S;
+  constexpr string_view(int Size, const char *Str) : D(Str), S(Size) {}
----------------
hubert-reinterpretcast wrote:

> Should there be a separate PR to make the ordering consistent for all the testcases?

Yes: to avoid churn around the inconsistency with `std::string_view` in future PRs that also use the existing tests as a basis.
Please create the separate PR, but update (as applicable) all of the tests added in this PR here.

Note also, when making the changes, that the order of the members should be made consistent as well. For example, in this file as currently proposed by this PR, the constructor argument order disagrees with the declaration order of the members (and the syntactic ordering of the corresponding constructor initializers): all of these should be made consistent with `std::string_view`.

https://github.com/llvm/llvm-project/pull/169803


More information about the cfe-commits mailing list