[clang] [clang] Silence "not all control paths return" diagnostic; NFC (PR #240528)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 12:05:41 PST 2026


https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/240528

The switch is fully covered but MSVC diagnoses anyway

>From 01f6b5e3822b71fe810ce715dfa9558c6b352d10 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Mon, 9 Nov 2026 15:03:18 -0500
Subject: [PATCH] [clang] Silence "not all control paths return" diagnostic;
 NFC

The switch is fully covered but MSVC diagnoses anyway
---
 clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
index 74014b58ad8453..33f2d4782db119 100644
--- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
+++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
@@ -326,6 +326,7 @@ class SimpleBoolModel final : public Environment::BoolModel {
       return *V_L == *V_R;
     }
     }
+    llvm_unreachable("fully covered switch");
   }
 
   // Updates atom assignments under the assumption that subformula `F`



More information about the cfe-commits mailing list