[clang] [Clang][Inliner] Enable module-local optimizer hints by default (PR #238529)

Kuba Mracek via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 02:53:38 PST 2026


kubamracek wrote:

> > (1) opt-out via -fno-module-local-hints in RUN lines -- there's over a 100 test changes like that because the alternative would often be that we need to split attr groups and complicate the CHECK lines...
> 
> A lot of those are generated tests, you should be able to just regenerate the check lines instead.

Ok, I have regenerated a bunch. But there's still a decent amount (60+) that don't work after re-generation, a lot of it is tests checking that the IR coming from direct compilation vs. through a PCH (mostly the OpenMP tests) is the same and they use the same CHECK group. Would you prefer in those cases to further duplicate the whole CHECK group? (Some of those tests are already massive and already duplicate the CHECK lines heavily, e.g. https://github.com/llvm/llvm-project/blob/main/clang/test/OpenMP/distribute_codegen.cpp)

https://github.com/llvm/llvm-project/pull/238529


More information about the cfe-commits mailing list