[clang] [flang] [flang][OpenMP] Globalize MAIN scalars used in parallel regions (PR #236384)
Sergey Shcherbinin via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 9 02:29:06 PST 2026
SergeyShch01 wrote:
@eugeneepshteyn,
Thank you for the detailed review. I've tried to address the comments in the updated revision:
- Moved the selected globals into `pft::Program`, removing semantic-symbol mutations, and added an ON/OFF/ON PFT isolation test.
- Removed the separate parse-tree walker and shared the existing symbol traversal with `visitAllSymbols`.
- Added selection through elemental intrinsic value arguments, including `ABS`, while excluding inquiry-only operands.
- Defined privatizer suffixes once and reused them in both name generation and the collision filter.
- Replaced debug-output counts with checks of generated IR.
- Removed the AArch64-specific optimized-loop checks; the miniWeather case now checks storage selection and bindings in HLFIR.
- Opened #240308 for the general host-binding cache, with compile-time measurements.
The MAIN-only cache path is still present in this PR, so removing it remains outstanding. I have not repeated the Clang 17 build-time and `.text` size measurements.
https://github.com/llvm/llvm-project/pull/236384
More information about the cfe-commits
mailing list