[clang] [llvm] [NFC][SPIRV] Clean up the Global Registry when removing an instruction (PR #239297)
Alex Voicu via cfe-commits
cfe-commits at lists.llvm.org
Sun Nov 8 12:05:12 PST 2026
https://github.com/AlexVlx commented:
> I wasn't able to reproduce the bug (gcc 11.4.0), but it looks real.
>
> LegalizePointerCast has the same map to clean. Also my favoring _thing_ in type rewriter - `TodoType` is also not being reset. Arguably there should be more places to fix it. Which makes me leaning towards:
>
That's fine by me. What I suggest we consider doing is the following:
- take this NFC for now as it fixes concrete breakage that users will run into if they try to generate use the size optimisation option we recently added;
- I'll spend some time on the rework and create a new PR with that.
> > An alternative solution might be to rework things so that we collect all values that could trigger this, and process them together, with no intervening creations / erasures.
https://github.com/llvm/llvm-project/pull/239297
More information about the cfe-commits
mailing list