[clang] [perf-training][merge-fdata] Clean up input fdata files (PR #139650)

Madhur Amilkanthwar via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 7 03:50:50 PST 2026


madhur13490 wrote:

Hi @aaupov,

This PR breaks the BOLT perf-training step (clang-bolt / stage2-clang-bolt) in our downstream CI. merge_fdata now passes the whole list of input files to subprocess.check_call as a single argument:

```

inputs = findFilesWithExtension(args[2], "fdata")
subprocess.check_call([args[0], inputs, "-o", args[1]])
```

subprocess needs every argument to be a string, so it fails right after the bolt-fdata lit run:

```
  File ".../clang/utils/perf-training/perf-helper.py", line 77, in merge_fdata
    subprocess.check_call([args[0], inputs, "-o", args[1]])
 ```

TypeError: expected str, bytes or os.PathLike object, not list
Before this change the list was spread with cmd.extend(...). 

Unpacking it should fix the problem:
`subprocess.check_call([args[0], *inputs, "-o", args[1]])
`


Could you push a fix, or should I send a PR? Thanks!

https://github.com/llvm/llvm-project/pull/139650


More information about the cfe-commits mailing list