[clang] [clang][CIR] Explicitly cast values to avoid narrowing implicit conversion (PR #239951)
Hardik Kumar via cfe-commits
cfe-commits at lists.llvm.org
Sat Nov 7 02:52:02 PST 2026
https://github.com/hardikxk created https://github.com/llvm/llvm-project/pull/239951
Use `static_cast` to explicitly convert the 64 bit int values to the expected `int32_t` type to avoid narrowing implicit conversions from 64 bit int to 32 bit int values.
>From 4b1369305541712d4c9fbf3ee3f235aafc563d12 Mon Sep 17 00:00:00 2001
From: Hardik Kumar <hardikxk at gmail.com>
Date: Sat, 7 Nov 2026 16:17:39 +0530
Subject: [PATCH] [clang][CIR] Explicitly cast values to avoid narrowing
implicit conversion
Use `static_cast` to explicitly convert the 64 bit int values to the
expected `int32_t` type to avoid narrowing implicit conversions from 64 bit int
to 32 bit int values.
Signed-off-by: Hardik Kumar <hardikxk at gmail.com>
---
clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
index 3836c3f610315..0dad183376051 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -2327,7 +2327,7 @@ mlir::LogicalResult CIRToLLVMBaseClassAddrOpLowering::matchAndRewrite(
return emitTypeConversionError(baseClassOp, baseClassOp.getType());
mlir::Value derivedAddr = adaptor.getSrcAddr();
llvm::SmallVector<mlir::LLVM::GEPArg, 1> offset = {
- adaptor.getOffset().getZExtValue()};
+ static_cast<int32_t>(adaptor.getOffset().getZExtValue())};
mlir::Type byteType = mlir::IntegerType::get(resultType.getContext(), 8,
mlir::IntegerType::Signless);
if (adaptor.getOffset().getZExtValue() == 0) {
@@ -2368,7 +2368,8 @@ mlir::LogicalResult CIRToLLVMDerivedClassAddrOpLowering::matchAndRewrite(
rewriter.replaceOp(derivedClassOp, baseAddr);
return mlir::success();
}
- llvm::SmallVector<mlir::LLVM::GEPArg, 1> offset = {offsetVal};
+ llvm::SmallVector<mlir::LLVM::GEPArg, 1> offset = {
+ static_cast<int32_t>(offsetVal)};
mlir::Type byteType = mlir::IntegerType::get(resultType.getContext(), 8,
mlir::IntegerType::Signless);
if (derivedClassOp.getAssumeNotNull()) {
@@ -5618,7 +5619,8 @@ mlir::LogicalResult CIRToLLVMVTableGetVirtualFnAddrOpLowering::matchAndRewrite(
return emitTypeConversionError(op, op.getType());
auto eltType = mlir::LLVM::LLVMPointerType::get(rewriter.getContext());
llvm::SmallVector<mlir::LLVM::GEPArg> offsets =
- llvm::SmallVector<mlir::LLVM::GEPArg>{op.getIndex()};
+ llvm::SmallVector<mlir::LLVM::GEPArg>{
+ static_cast<int32_t>(op.getIndex())};
rewriter.replaceOpWithNewOp<mlir::LLVM::GEPOp>(
op, targetType, eltType, adaptor.getVptr(), offsets,
mlir::LLVM::GEPNoWrapFlags::inbounds);
More information about the cfe-commits
mailing list