[clang] [CIR] Omit uniform work-group size attributes from aliases (PR #239815)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 6 14:03:52 PST 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Akimasa Watanuki (Men-cotton)
<details>
<summary>Changes</summary>
Omit `uniform_work_group_size` when lowering function aliases, since the attribute describes functions and call sites and has no meaning on LLVM aliases.
Assisted-by: Codex / GPT-6
---
Full diff: https://github.com/llvm/llvm-project/pull/239815.diff
2 Files Affected:
- (modified) clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp (+3)
- (added) clang/test/CIR/Lowering/uniform-work-group-size.cir (+11)
``````````diff
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
index 2d3ded9796e22..bf9f5ee17d61f 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -3147,6 +3147,9 @@ mlir::LogicalResult CIRToLLVMFuncOpLowering::lowerFuncAttributes(
for (mlir::NamedAttribute attr : func->getDiscardableAttrs()) {
if (isHandledDiscardableFuncAttr(attr))
continue;
+ if (!includeFunctionOnlyAttrs &&
+ attr.getName() == CIRDialect::getUniformWorkGroupSizeAttrName())
+ continue;
if (openCLMetadataLowering.lower(attr, includeFunctionOnlyAttrs))
continue;
assert(!cir::MissingFeatures::opFuncExtraAttrs());
diff --git a/clang/test/CIR/Lowering/uniform-work-group-size.cir b/clang/test/CIR/Lowering/uniform-work-group-size.cir
new file mode 100644
index 0000000000000..346219591748d
--- /dev/null
+++ b/clang/test/CIR/Lowering/uniform-work-group-size.cir
@@ -0,0 +1,11 @@
+// RUN: cir-opt %s -cir-to-llvm | FileCheck %s
+
+module attributes {cir.triple = "x86_64-unknown-linux-gnu"} {
+ cir.func @target() attributes {uniform_work_group_size} {
+ cir.return
+ }
+ cir.func @alias() alias(@target) attributes {uniform_work_group_size}
+}
+
+// CHECK-LABEL: llvm.mlir.alias external @alias
+// CHECK-NOT: uniform_work_group_size
``````````
</details>
https://github.com/llvm/llvm-project/pull/239815
More information about the cfe-commits
mailing list