[clang] 3844c99 - [clang][Parse][NFC] Share parsing for astype and convertvector builtins (#239107)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 5 16:01:39 PST 2026
Author: Chen Miao
Date: 2026-11-06T08:01:34+08:00
New Revision: 3844c998b8b6bef7ce0ca66de9ad63bfc37d4085
URL: https://github.com/llvm/llvm-project/commit/3844c998b8b6bef7ce0ca66de9ad63bfc37d4085
DIFF: https://github.com/llvm/llvm-project/commit/3844c998b8b6bef7ce0ca66de9ad63bfc37d4085.diff
LOG: [clang][Parse][NFC] Share parsing for astype and convertvector builtins (#239107)
Share the parsing logic for __builtin_astype and
__builtin_convertvector, then dispatch to their respective Sema actions.
Preserve diagnostics and error recovery.
Added:
Modified:
clang/lib/Parse/ParseExpr.cpp
Removed:
################################################################################
diff --git a/clang/lib/Parse/ParseExpr.cpp b/clang/lib/Parse/ParseExpr.cpp
index d42ffc2ccf0a6..14a55cfecfb8e 100644
--- a/clang/lib/Parse/ParseExpr.cpp
+++ b/clang/lib/Parse/ParseExpr.cpp
@@ -2524,35 +2524,7 @@ ExprResult Parser::ParseBuiltinPrimaryExpression() {
Expr2.get(), ConsumeParen());
break;
}
- case tok::kw___builtin_astype: {
- // The first argument is an expression to be converted, followed by a comma.
- ExprResult Expr(ParseAssignmentExpression());
- if (Expr.isInvalid()) {
- SkipUntil(tok::r_paren, StopAtSemi);
- return ExprError();
- }
-
- if (ExpectAndConsume(tok::comma)) {
- SkipUntil(tok::r_paren, StopAtSemi);
- return ExprError();
- }
-
- // Second argument is the type to bitcast to.
- TypeResult DestTy = ParseTypeName();
- if (DestTy.isInvalid())
- return ExprError();
-
- // Attempt to consume the r-paren.
- if (Tok.isNot(tok::r_paren)) {
- Diag(Tok, diag::err_expected) << tok::r_paren;
- SkipUntil(tok::r_paren, StopAtSemi);
- return ExprError();
- }
-
- Res = Actions.ActOnAsTypeExpr(Expr.get(), DestTy.get(), StartLoc,
- ConsumeParen());
- break;
- }
+ case tok::kw___builtin_astype:
case tok::kw___builtin_convertvector: {
// The first argument is an expression to be converted, followed by a comma.
ExprResult Expr(ParseAssignmentExpression());
@@ -2578,8 +2550,12 @@ ExprResult Parser::ParseBuiltinPrimaryExpression() {
return ExprError();
}
- Res = Actions.ActOnConvertVectorExpr(Expr.get(), DestTy.get(), StartLoc,
- ConsumeParen());
+ if (T == tok::kw___builtin_astype)
+ Res = Actions.ActOnAsTypeExpr(Expr.get(), DestTy.get(), StartLoc,
+ ConsumeParen());
+ else
+ Res = Actions.ActOnConvertVectorExpr(Expr.get(), DestTy.get(), StartLoc,
+ ConsumeParen());
break;
}
case tok::kw___builtin_COLUMN:
More information about the cfe-commits
mailing list