[clang] [clang][HIP] Disallow non-constant format string with pointer argument (PR #238287)
Yaxun Liu via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 5 13:00:29 PST 2026
================
@@ -2499,6 +2500,34 @@ checkMathBuiltinElementType(Sema &S, SourceLocation Loc, QualType ArgTy,
return false;
}
+/// The AMDGPU printf lowering can only find %s specifiers in a format string
+/// known at compile time, so with any other format a string argument would be
+/// printed as its address. Any pointer argument may be a string, so reject it.
+static void checkAMDGPUDevicePrintf(Sema &S, CallExpr *TheCall) {
+ const llvm::Triple &TT = S.Context.getTargetInfo().getTriple();
+ if (!S.getLangOpts().HIP ||
+ !(TT.isAMDGCN() || (TT.isSPIRV() && TT.getVendor() == llvm::Triple::AMD)))
+ return;
+ if (TheCall->getNumArgs() < 2 || TheCall->isValueDependent() ||
----------------
yxsamliu wrote:
Could we skip unevaluated expressions here? `sizeof(printf(fmt, str))` never calls printf, so it should not trigger this error. Please add a test for this case.
https://github.com/llvm/llvm-project/pull/238287
More information about the cfe-commits
mailing list