[clang] Add diag for ctor initializers + increase limit (PR #239011)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 5 08:54:34 PST 2026
erichkeane wrote:
> > but that causes modules to 'load' a ton of data when checking some pretty innocuous things(like whether it is a delgating constructor!), so that seemed worse.
>
> We could devote one bit to "has a non-zero number of initializers" and one bit to "is a delegating constructor".
>
> But I'm okay with just storing it separately.
Hmm... an interesting idea. I might actually suggest something more akin to a 2 bit 'size' field, that stores 0, 1, or 2 as a shortcut, with `3` meaning "you have to load it".
That said, I suspect that is quite a bit of additional complexity for quite little gain.
I have an approval from Corentin, but please let me know if you'd like to do a review (or are happy with this landing as-is), and I'll wait your comments.
https://github.com/llvm/llvm-project/pull/239011
More information about the cfe-commits
mailing list