[clang] [llvm] [ORC] Remove dead code from EPCDynamicLibrarySearchGenerator. (PR #239008)
Lang Hames via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 4 19:19:46 PST 2026
https://github.com/lhames updated https://github.com/llvm/llvm-project/pull/239008
>From 81bb461d3f9e40e5779b49d4c06929b67e57ed8c Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Wed, 4 Nov 2026 10:52:29 +1100
Subject: [PATCH 1/7] [ORC] Remove dead code from
EPCDynamicLibrarySearchGenerator.
Search generators should not error on missing symbols (the search should
be allowed to fall through to subsequent generators and dylibs in the
search order). EPCDynamicLibrarySearchGenerator::tryToGenerate supports
this by using WeaklyReferencedSymbol for all search elements, but also
had an unreachable "missing symbols" error path. This commit removes the
unreachable error path.
---
.../Orc/EPCDynamicLibrarySearchGenerator.cpp | 14 ++------------
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
index 9d31287445a0d4..4f256bde2aefa8 100644
--- a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
@@ -77,15 +77,11 @@ Error EPCDynamicLibrarySearchGenerator::tryToGenerate(
"Result has incorrect number of elements");
auto SymsIt = Result->begin();
- SymbolNameSet MissingSymbols;
SymbolMap NewSymbols;
for (auto &[Name, Flags] : LookupSymbols) {
const auto &Sym = *SymsIt++;
if (Sym && *Sym)
NewSymbols[Name] = {*Sym, JITSymbolFlags::Exported};
- else if (LLVM_UNLIKELY(!Sym &&
- Flags == SymbolLookupFlags::RequiredSymbol))
- MissingSymbols.insert(Name);
}
LLVM_DEBUG({
@@ -93,18 +89,12 @@ Error EPCDynamicLibrarySearchGenerator::tryToGenerate(
<< NewSymbols << "\n";
});
- // If there were no resolved symbols bail out.
+ // If no resolved symbols then exit early with success.
if (NewSymbols.empty())
return LS.continueLookup(Error::success());
- if (LLVM_UNLIKELY(!MissingSymbols.empty()))
- return LS.continueLookup(make_error<SymbolsNotFound>(
- this->ES.getSymbolStringPool(), std::move(MissingSymbols)));
-
// Define resolved symbols.
- Error Err = addAbsolutes(JD, std::move(NewSymbols));
-
- LS.continueLookup(std::move(Err));
+ LS.continueLookup(addAbsolutes(JD, std::move(NewSymbols)));
});
return Error::success();
>From d49f37a1204550bd24b56eda707b2f1273e0a018 Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Thu, 5 Nov 2026 10:21:21 +1100
Subject: [PATCH 2/7] Remove now-unused ES member.
---
.../Orc/EPCDynamicLibrarySearchGenerator.h | 9 ++++-----
.../Orc/EPCDynamicLibrarySearchGenerator.cpp | 4 ++--
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h b/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
index 43f7751f2dfdb7..78419119a2e26a 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
@@ -39,7 +39,7 @@ class LLVM_ABI EPCDynamicLibrarySearchGenerator : public DefinitionGenerator {
/// If \p AddAbsoluteSymbols is provided, it is used to add the symbols to the
/// \c JITDylib; otherwise it uses JD.define(absoluteSymbols(...)).
EPCDynamicLibrarySearchGenerator(
- ExecutionSession &ES, DylibManager &DylibMgr, tpctypes::DylibHandle H,
+ DylibManager &DylibMgr, tpctypes::DylibHandle H,
SymbolPredicate Allow = SymbolPredicate(),
AddAbsoluteSymbolsFn AddAbsoluteSymbols = nullptr)
: ES(ES), DylibMgr(DylibMgr), H(H), Allow(std::move(Allow)),
@@ -53,7 +53,7 @@ class LLVM_ABI EPCDynamicLibrarySearchGenerator : public DefinitionGenerator {
/// "missing symbol" behavior in ORC. This distinction shouldn't matter for
/// most use-cases).
EPCDynamicLibrarySearchGenerator(
- ExecutionSession &ES, DylibManager &DylibMgr, SymbolPredicate Allow,
+ DylibManager &DylibMgr, SymbolPredicate Allow,
AddAbsoluteSymbolsFn AddAbsoluteSymbols = nullptr)
: ES(ES), DylibMgr(DylibMgr), Allow(std::move(Allow)),
AddAbsoluteSymbols(std::move(AddAbsoluteSymbols)) {}
@@ -63,14 +63,14 @@ class LLVM_ABI EPCDynamicLibrarySearchGenerator : public DefinitionGenerator {
/// definitions in the library. On failure returns the reason the library
/// failed to load.
static Expected<std::unique_ptr<EPCDynamicLibrarySearchGenerator>>
- Load(ExecutionSession &ES, DylibManager &DylibMgr, const char *LibraryPath,
+ Load(DylibManager &DylibMgr, const char *LibraryPath,
SymbolPredicate Allow = SymbolPredicate(),
AddAbsoluteSymbolsFn AddAbsoluteSymbols = nullptr);
/// Creates a EPCDynamicLibrarySearchGenerator that searches for symbols in
/// the target process.
static Expected<std::unique_ptr<EPCDynamicLibrarySearchGenerator>>
- GetForTargetProcess(ExecutionSession &ES, DylibManager &DylibMgr,
+ GetForTargetProcess(DylibManager &DylibMgr,
SymbolPredicate Allow = SymbolPredicate(),
AddAbsoluteSymbolsFn AddAbsoluteSymbols = nullptr) {
return Load(ES, DylibMgr, nullptr, std::move(Allow),
@@ -84,7 +84,6 @@ class LLVM_ABI EPCDynamicLibrarySearchGenerator : public DefinitionGenerator {
private:
Error addAbsolutes(JITDylib &JD, SymbolMap Symbols);
- ExecutionSession &ES;
DylibManager &DylibMgr;
std::optional<tpctypes::DylibHandle> H;
SymbolPredicate Allow;
diff --git a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
index 4f256bde2aefa8..ba247bc715cfaa 100644
--- a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
@@ -19,14 +19,14 @@ namespace orc {
Expected<std::unique_ptr<EPCDynamicLibrarySearchGenerator>>
EPCDynamicLibrarySearchGenerator::Load(
- ExecutionSession &ES, DylibManager &DylibMgr, const char *LibraryPath,
+ DylibManager &DylibMgr, const char *LibraryPath,
SymbolPredicate Allow, AddAbsoluteSymbolsFn AddAbsoluteSymbols) {
auto Handle = DylibMgr.loadDylib(LibraryPath);
if (!Handle)
return Handle.takeError();
return std::make_unique<EPCDynamicLibrarySearchGenerator>(
- ES, DylibMgr, *Handle, std::move(Allow), std::move(AddAbsoluteSymbols));
+ DylibMgr, *Handle, std::move(Allow), std::move(AddAbsoluteSymbols));
}
Error EPCDynamicLibrarySearchGenerator::tryToGenerate(
>From 760659d2ac9c715666a433fae2f5b7e39a31f06e Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Thu, 5 Nov 2026 10:32:36 +1100
Subject: [PATCH 3/7] clang-format
---
.../ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
index ba247bc715cfaa..eaa27622b73fcc 100644
--- a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
@@ -19,8 +19,8 @@ namespace orc {
Expected<std::unique_ptr<EPCDynamicLibrarySearchGenerator>>
EPCDynamicLibrarySearchGenerator::Load(
- DylibManager &DylibMgr, const char *LibraryPath,
- SymbolPredicate Allow, AddAbsoluteSymbolsFn AddAbsoluteSymbols) {
+ DylibManager &DylibMgr, const char *LibraryPath, SymbolPredicate Allow,
+ AddAbsoluteSymbolsFn AddAbsoluteSymbols) {
auto Handle = DylibMgr.loadDylib(LibraryPath);
if (!Handle)
return Handle.takeError();
>From c40d1cd21d704ef4bd10f99dc03f65583cd022af Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Thu, 5 Nov 2026 11:49:59 +1100
Subject: [PATCH 4/7] propagate removal of ES param
---
clang/lib/Interpreter/OrcIncrementalExecutor.cpp | 3 +--
.../ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h | 6 +++---
llvm/lib/ExecutionEngine/Orc/LLJIT.cpp | 4 ++--
llvm/tools/llvm-jitlink/llvm-jitlink.cpp | 6 +++---
.../ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp | 2 +-
orc-rt/include/CMakeLists.txt | 1 +
orc-rt/lib/bedrock/CMakeLists.txt | 2 ++
7 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/clang/lib/Interpreter/OrcIncrementalExecutor.cpp b/clang/lib/Interpreter/OrcIncrementalExecutor.cpp
index 7134437e6a9adb..75066db023ed18 100644
--- a/clang/lib/Interpreter/OrcIncrementalExecutor.cpp
+++ b/clang/lib/Interpreter/OrcIncrementalExecutor.cpp
@@ -108,9 +108,8 @@ OrcIncrementalExecutor::getSymbolAddress(llvm::StringRef Name,
llvm::Error OrcIncrementalExecutor::LoadDynamicLibrary(const char *name) {
// FIXME: Eventually we should put each library in its own JITDylib and
// turn off process symbols by default.
- llvm::orc::ExecutionSession &ES = Jit->getExecutionSession();
auto DLSGOrErr = llvm::orc::EPCDynamicLibrarySearchGenerator::Load(
- ES, Jit->getDylibMgr(), name);
+ Jit->getDylibMgr(), name);
if (!DLSGOrErr)
return DLSGOrErr.takeError();
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h b/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
index 78419119a2e26a..2e1817c806cd67 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
@@ -42,7 +42,7 @@ class LLVM_ABI EPCDynamicLibrarySearchGenerator : public DefinitionGenerator {
DylibManager &DylibMgr, tpctypes::DylibHandle H,
SymbolPredicate Allow = SymbolPredicate(),
AddAbsoluteSymbolsFn AddAbsoluteSymbols = nullptr)
- : ES(ES), DylibMgr(DylibMgr), H(H), Allow(std::move(Allow)),
+ : DylibMgr(DylibMgr), H(H), Allow(std::move(Allow)),
AddAbsoluteSymbols(std::move(AddAbsoluteSymbols)) {}
/// Create an EPCDynamicLibrarySearchGenerator that resolves all symbols
@@ -55,7 +55,7 @@ class LLVM_ABI EPCDynamicLibrarySearchGenerator : public DefinitionGenerator {
EPCDynamicLibrarySearchGenerator(
DylibManager &DylibMgr, SymbolPredicate Allow,
AddAbsoluteSymbolsFn AddAbsoluteSymbols = nullptr)
- : ES(ES), DylibMgr(DylibMgr), Allow(std::move(Allow)),
+ : DylibMgr(DylibMgr), Allow(std::move(Allow)),
AddAbsoluteSymbols(std::move(AddAbsoluteSymbols)) {}
/// Permanently loads the library at the given path and, on success, returns
@@ -73,7 +73,7 @@ class LLVM_ABI EPCDynamicLibrarySearchGenerator : public DefinitionGenerator {
GetForTargetProcess(DylibManager &DylibMgr,
SymbolPredicate Allow = SymbolPredicate(),
AddAbsoluteSymbolsFn AddAbsoluteSymbols = nullptr) {
- return Load(ES, DylibMgr, nullptr, std::move(Allow),
+ return Load(DylibMgr, nullptr, std::move(Allow),
std::move(AddAbsoluteSymbols));
}
diff --git a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp
index 5fabdad8c1c28e..7c97666b79a947 100644
--- a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp
@@ -840,7 +840,7 @@ Error LLJITBuilderState::prepareForConstruction() {
auto &JD =
J.getExecutionSession().createBareJITDylib("<Process Symbols>");
auto G = EPCDynamicLibrarySearchGenerator::GetForTargetProcess(
- J.getExecutionSession(), J.getDylibMgr());
+ J.getDylibMgr());
if (!G)
return G.takeError();
JD.addGenerator(std::move(*G));
@@ -870,7 +870,7 @@ Expected<JITDylib &> LLJIT::createJITDylib(std::string Name) {
}
Expected<JITDylib &> LLJIT::loadPlatformDynamicLibrary(const char *Path) {
- auto G = EPCDynamicLibrarySearchGenerator::Load(*ES, *DylibMgr, Path);
+ auto G = EPCDynamicLibrarySearchGenerator::Load(*DylibMgr, Path);
if (!G)
return G.takeError();
diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
index 0bc4112fd94e49..1589e284025f0c 100644
--- a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
+++ b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
@@ -909,7 +909,7 @@ static Error loadProcessSymbols(Session &S) {
};
S.ProcessSymsJD->addGenerator(
ExitOnErr(orc::EPCDynamicLibrarySearchGenerator::GetForTargetProcess(
- S.ES, *S.DylibMgr, std::move(FilterMainEntryPoint))));
+ *S.DylibMgr, std::move(FilterMainEntryPoint))));
return Error::success();
}
@@ -1603,7 +1603,7 @@ Expected<JITDylib *> Session::getOrLoadDynamicLibrary(StringRef LibPath) {
if (It != DynLibJDs.end())
return It->second;
auto G =
- EPCDynamicLibrarySearchGenerator::Load(ES, *DylibMgr, LibPath.data());
+ EPCDynamicLibrarySearchGenerator::Load(*DylibMgr, LibPath.data());
if (!G)
return G.takeError();
auto JD = &ES.createBareJITDylib(LibPath.str());
@@ -2392,7 +2392,7 @@ LoadLibraryWeak(Session &S, StringRef Path) {
return Symbols.takeError();
return std::make_unique<EPCDynamicLibrarySearchGenerator>(
- S.ES, *S.DylibMgr,
+ *S.DylibMgr,
[Symbols = std::move(*Symbols)](const SymbolStringPtr &Sym) {
return Symbols.count(Sym);
});
diff --git a/llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
index 0db37d7203fbd9..df0b74abd9b8ee 100644
--- a/llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
@@ -324,7 +324,7 @@ TEST(ObjectLinkingLayerSearchGeneratorTest, AbsoluteSymbolsObjectLayer) {
ES, std::make_unique<InProcessMemoryManager>(4096)};
auto G = EPCDynamicLibrarySearchGenerator::GetForTargetProcess(
- ES, TestDylibMgr, {}, [&](JITDylib &JD, SymbolMap Syms) {
+ TestDylibMgr, {}, [&](JITDylib &JD, SymbolMap Syms) {
auto G =
absoluteSymbolsLinkGraph(Triple("x86_64-apple-darwin"),
ES.getSymbolStringPool(), std::move(Syms));
diff --git a/orc-rt/include/CMakeLists.txt b/orc-rt/include/CMakeLists.txt
index 9d77b71333a24f..19a463d2d3f0fa 100644
--- a/orc-rt/include/CMakeLists.txt
+++ b/orc-rt/include/CMakeLists.txt
@@ -21,6 +21,7 @@ set(ORC_RT_HEADERS
orc-rt/bedrock/Session.h
orc-rt/bedrock/SimpleNativeMemoryMap.h
orc-rt/bedrock/SimpleSymbolTable.h
+ orc-rt/bedrock/SymbolResolver.h
orc-rt/bedrock/TaskGroup.h
orc-rt/bedrock/ThreadPoolRunner.h
orc-rt/bedrock/sps/AllSPSCI.h
diff --git a/orc-rt/lib/bedrock/CMakeLists.txt b/orc-rt/lib/bedrock/CMakeLists.txt
index 510e5973730968..1963a846fac67c 100644
--- a/orc-rt/lib/bedrock/CMakeLists.txt
+++ b/orc-rt/lib/bedrock/CMakeLists.txt
@@ -9,10 +9,12 @@ set(ORC_RT_BEDROCK_SOURCES
Session.cpp
SimpleNativeMemoryMap.cpp
SimpleSymbolTable.cpp
+ SymbolResolver.cpp
ThreadPoolRunner.cpp
sps/AllSPSCI.cpp
sps/CallSPSCI.cpp
sps/GDBJITRegistrarSPSCI.cpp
+ sps/LookupInJITDylibSPS.cpp
sps/MemoryAccessSPSCI.cpp
sps/NativeDylibManagerSPSCI.cpp
sps/SessionSPSCI.cpp
>From 75b88800ab78fa9997ae3dacc378985946e48b5b Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Thu, 5 Nov 2026 11:50:14 +1100
Subject: [PATCH 5/7] clang-format
---
llvm/tools/llvm-jitlink/llvm-jitlink.cpp | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
index 1589e284025f0c..54f26e85b35196 100644
--- a/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
+++ b/llvm/tools/llvm-jitlink/llvm-jitlink.cpp
@@ -1602,8 +1602,7 @@ Expected<JITDylib *> Session::getOrLoadDynamicLibrary(StringRef LibPath) {
auto It = DynLibJDs.find(LibPath);
if (It != DynLibJDs.end())
return It->second;
- auto G =
- EPCDynamicLibrarySearchGenerator::Load(*DylibMgr, LibPath.data());
+ auto G = EPCDynamicLibrarySearchGenerator::Load(*DylibMgr, LibPath.data());
if (!G)
return G.takeError();
auto JD = &ES.createBareJITDylib(LibPath.str());
@@ -2392,8 +2391,7 @@ LoadLibraryWeak(Session &S, StringRef Path) {
return Symbols.takeError();
return std::make_unique<EPCDynamicLibrarySearchGenerator>(
- *S.DylibMgr,
- [Symbols = std::move(*Symbols)](const SymbolStringPtr &Sym) {
+ *S.DylibMgr, [Symbols = std::move(*Symbols)](const SymbolStringPtr &Sym) {
return Symbols.count(Sym);
});
}
>From 6809f52cbd0f05135ca2875ac6f1a369560a5f66 Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Thu, 5 Nov 2026 14:19:18 +1100
Subject: [PATCH 6/7] Remove more ES arguments
---
.../LLJITWithRemoteDebugging/LLJITWithRemoteDebugging.cpp | 2 +-
.../OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp | 4 ++--
.../OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/LLJITWithRemoteDebugging.cpp b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/LLJITWithRemoteDebugging.cpp
index 995e3d7eb0d641..a6a34e57a3652e 100644
--- a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/LLJITWithRemoteDebugging.cpp
+++ b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/LLJITWithRemoteDebugging.cpp
@@ -187,7 +187,7 @@ int main(int argc, char *argv[]) {
// for each of it, so the compiler can lookup their symbols.
for (const std::string &Path : Dylibs)
J->getMainJITDylib().addGenerator(
- ExitOnErr(loadDylib(J->getExecutionSession(), J->getDylibMgr(), Path)));
+ ExitOnErr(loadDylib(J->getDylibMgr(), Path)));
// Add the loaded IR module to the JIT. This will set up symbol tables and
// prepare for materialization.
diff --git a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp
index 0e7e2c2426dcaa..e2e8343d1fd8fd 100644
--- a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp
+++ b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp
@@ -27,9 +27,9 @@ using namespace llvm;
using namespace llvm::orc;
Expected<std::unique_ptr<DefinitionGenerator>>
-loadDylib(ExecutionSession &ES, DylibManager &DylibMgr, StringRef RemotePath) {
+loadDylib(DylibManager &DylibMgr, StringRef RemotePath) {
if (auto Handle = DylibMgr.loadDylib(RemotePath.data()))
- return std::make_unique<EPCDynamicLibrarySearchGenerator>(ES, DylibMgr,
+ return std::make_unique<EPCDynamicLibrarySearchGenerator>(DylibMgr,
*Handle);
else
return Handle.takeError();
diff --git a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h
index 70f08787798d79..37e604073da716 100644
--- a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h
+++ b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h
@@ -38,7 +38,7 @@ llvm::Expected<std::unique_ptr<llvm::orc::SimpleRemoteEPC>>
connectTCPSocket(llvm::StringRef NetworkAddress);
llvm::Expected<std::unique_ptr<llvm::orc::DefinitionGenerator>>
-loadDylib(llvm::orc::ExecutionSession &ES, llvm::orc::DylibManager &DylibMgr,
+loadDylib(llvm::orc::DylibManager &DylibMgr,
llvm::StringRef RemotePath);
#endif
>From a06e9c43eb7abdf4be4b9f61bf99ad2e89ce9d06 Mon Sep 17 00:00:00 2001
From: Lang Hames <lhames at gmail.com>
Date: Thu, 5 Nov 2026 14:19:27 +1100
Subject: [PATCH 7/7] clang-format
---
.../OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp | 4 ++--
.../OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp
index e2e8343d1fd8fd..c35dfff3cce657 100644
--- a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp
+++ b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.cpp
@@ -26,8 +26,8 @@
using namespace llvm;
using namespace llvm::orc;
-Expected<std::unique_ptr<DefinitionGenerator>>
-loadDylib(DylibManager &DylibMgr, StringRef RemotePath) {
+Expected<std::unique_ptr<DefinitionGenerator>> loadDylib(DylibManager &DylibMgr,
+ StringRef RemotePath) {
if (auto Handle = DylibMgr.loadDylib(RemotePath.data()))
return std::make_unique<EPCDynamicLibrarySearchGenerator>(DylibMgr,
*Handle);
diff --git a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h
index 37e604073da716..64b4e124f1f931 100644
--- a/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h
+++ b/llvm/examples/OrcV2Examples/LLJITWithRemoteDebugging/RemoteJITUtils.h
@@ -38,7 +38,6 @@ llvm::Expected<std::unique_ptr<llvm::orc::SimpleRemoteEPC>>
connectTCPSocket(llvm::StringRef NetworkAddress);
llvm::Expected<std::unique_ptr<llvm::orc::DefinitionGenerator>>
-loadDylib(llvm::orc::DylibManager &DylibMgr,
- llvm::StringRef RemotePath);
+loadDylib(llvm::orc::DylibManager &DylibMgr, llvm::StringRef RemotePath);
#endif
More information about the cfe-commits
mailing list