[clang] [llvm] [TimeProfiler] Fix duration rounding bias (PR #228677)
Arthur Eubanks via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 4 13:48:52 PST 2026
================
@@ -91,29 +97,25 @@ struct llvm::TimeTraceProfilerEntry {
: Start(std::move(S)), End(std::move(E)), Name(std::move(N)),
Metadata(std::move(Mt)), EventType(Et) {}
- // Calculate timings for FlameGraph. Cast time points to microsecond precision
- // rather than casting duration. This avoids truncation issues causing inner
- // scopes overruning outer scopes.
+ // Calculate timings for FlameGraph. Strictly round down durations and
----------------
aeubanks wrote:
nit: the comment is too dense, very llm-like and hard to read as a human
https://github.com/llvm/llvm-project/pull/228677
More information about the cfe-commits
mailing list