[clang] [clang][Sema][NFC] Consolidate checking for vector reduction builtins (PR #238663)
Chen Miao via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 4 03:52:42 PST 2026
================
@@ -4119,12 +4074,22 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
return ExprError();
const Expr *Arg = TheCall->getArg(0);
-
QualType ElTy = getVectorElementType(Context, Arg->getType());
- if (ElTy.isNull() || !ElTy->isIntegerType()) {
+
+ bool FloatOnly = BuiltinID == Builtin::BI__builtin_reduce_maximum ||
+ BuiltinID == Builtin::BI__builtin_reduce_minimum;
+
+ bool IntOnly = BuiltinID == Builtin::BI__builtin_reduce_add ||
+ BuiltinID == Builtin::BI__builtin_reduce_mul ||
+ BuiltinID == Builtin::BI__builtin_reduce_xor ||
+ BuiltinID == Builtin::BI__builtin_reduce_or ||
+ BuiltinID == Builtin::BI__builtin_reduce_and;
+
+ if (ElTy.isNull() || (FloatOnly && !ElTy->isFloatingType()) ||
----------------
ChenMiaoi wrote:
That does seem to be the case, but it looks like _Complex can’t reach this point. Wouldn’t it be rejected in BuildVectorType?
https://github.com/llvm/llvm-project/pull/238663
More information about the cfe-commits
mailing list