[clang] [clang][-Wunsafe-buffer-usage] Add per-family subgroups of -Wunsafe-buffer-usage-in-libc-call (PR #233604)
Utkarsh Saxena via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 4 02:12:32 PST 2026
================
@@ -1140,93 +1149,59 @@ hasUnsafeFormatOrSArg(ASTContext &Ctx, const CallExpr *Call,
// 1. It's name, after stripping off predefined prefix and suffix, is
// `CoreName`; and
// 2. `CoreName` or `CoreName[str/wcs]` is one of the `PredefinedNames`, which
-// is a set of libc function names.
+// maps libc function names to their families.
//
// Note: For predefined prefix and suffix, see `matchName()`.
// The notation `CoreName[str/wcs]` means a new name obtained from replace
// string "wcs" with "str" in `CoreName`.
-static bool isPredefinedUnsafeLibcFunc(const FunctionDecl &Node) {
- static const std::set<StringRef> PredefinedNames = {
- // numeric conversion:
- "atof",
- "atoi",
- "atol",
- "atoll",
- "strtol",
- "strtoll",
- "strtoul",
- "strtoull",
- "strtof",
- "strtod",
- "strtold",
- "strtoimax",
- "strtoumax",
- // "strfromf", "strfromd", "strfroml", // C23?
- // string manipulation:
- "strcpy",
- "strncpy",
- "strlcpy",
- "strcat",
- "strncat",
- "strlcat",
- "strxfrm",
- "strdup",
- "strndup",
- // string examination:
- "strlen",
- "strnlen",
- "strcmp",
- "strncmp",
- "stricmp",
- "strcasecmp",
- "strcoll",
- "strchr",
- "strrchr",
- "strspn",
- "strcspn",
- "strpbrk",
- "strstr",
- "strtok",
- // "mem-" functions
- "memchr",
- "wmemchr",
- "memcmp",
- "wmemcmp",
- "memcpy",
- "memccpy",
- "mempcpy",
- "wmemcpy",
- "memmove",
- "wmemmove",
- "wmemset",
- // IO:
- "fread",
- "fwrite",
- "fgets",
- "fgetws",
- "gets",
- "fputs",
- "fputws",
- "puts",
- // others
- "strerror_s",
- "strerror_r",
- "bcopy",
- "bzero",
- "bsearch",
- "qsort",
- };
+//
+// Returns the family of the matched function, or std::nullopt if it does not
+// match.
+static std::optional<UnsafeLibcFunctionFamily>
+getPredefinedUnsafeLibcFuncFamily(const FunctionDecl &Node) {
+ static const llvm::StringMap<UnsafeLibcFunctionFamily> PredefinedNames = [] {
+ using F = UnsafeLibcFunctionFamily;
+ llvm::StringMap<F> M;
+ auto Add = [&](F Family, std::initializer_list<StringRef> Names) {
+ for (StringRef N : Names)
+ M[N] = Family;
+ };
+ // numeric conversion:
----------------
usx95 wrote:
nit: remove these comments as the enums are self-explanatory
https://github.com/llvm/llvm-project/pull/233604
More information about the cfe-commits
mailing list