[clang] [CIR] Remove 2 NYIs in CIRGenTypes.cpp (PR #238589)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 17:09:04 PST 2026


================
@@ -550,8 +550,6 @@ mlir::Type CIRGenTypes::convertType(QualType type) {
 
   case Type::VariableArray: {
     const VariableArrayType *a = cast<VariableArrayType>(ty);
----------------
andykaylor wrote:

Classic codegen asserts that `a->getIndexTypeCVRQualifiers() == 0` here and in the incomplete array case. Should we do that too? 

Both have a (19-year old!!) FIXME string that appears to have been [inherited from the general array handling](https://github.com/llvm/llvm-project/commit/2052bc810726672c19b3f59b91479efd61f9e67f#diff-e43a8ff6b76a450d57816dec06fdffb067e0572ca23ecb9dfd0bcd6572518ebd), so maybe not.

https://github.com/llvm/llvm-project/pull/238589


More information about the cfe-commits mailing list