[clang] [Hexagon] Search packaged builtins in resource dir (PR #238274)

via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 3 03:03:45 PST 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c -- clang/test/Driver/hexagon-library-search-path.c clang/lib/Driver/ToolChains/Hexagon.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Driver/ToolChains/Hexagon.cpp b/clang/lib/Driver/ToolChains/Hexagon.cpp
index 1b8943c6a..431b2f018 100644
--- a/clang/lib/Driver/ToolChains/Hexagon.cpp
+++ b/clang/lib/Driver/ToolChains/Hexagon.cpp
@@ -407,10 +407,11 @@ constructHexagonLinkArgs(Compilation &C, const JobAction &JA,
 
       if (!Args.hasArg(options::OPT_nolibc))
         CmdArgs.push_back("-lc");
-      // TODO: Linux (musl) ignores --rtlib and links -lclang_rt.builtins-hexagon,
-      // which does not match the packaged libclang_rt.builtins.a in
-      // <resource-dir>/lib/hexagon/<variant>. Use the same runtime selection and
-      // name as the other Hexagon targets, and update hexagon-toolchain-linux.c.
+      // TODO: Linux (musl) ignores --rtlib and links
+      // -lclang_rt.builtins-hexagon, which does not match the packaged
+      // libclang_rt.builtins.a in <resource-dir>/lib/hexagon/<variant>. Use the
+      // same runtime selection and name as the other Hexagon targets, and
+      // update hexagon-toolchain-linux.c.
       CmdArgs.push_back("-lclang_rt.builtins-hexagon");
     }
     if (D.CCCIsCXX()) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/238274


More information about the cfe-commits mailing list