[clang] [Clang][Modules][MS ABI] Don't drop resolved operator delete updates in reduced BMIs (PR #235673)
Chuanqi Xu via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 28 23:17:22 PDT 2026
================
@@ -5715,22 +5715,34 @@ void ASTWriter::prepareLazyUpdates() {
return;
DeclUpdateMap DeclUpdatesTmp;
- // Move updates to DeclUpdatesLazy but leave CXXAddedFunctionDefinition as is.
- // Since added function definition is critical to the AST. If we don't take
- // care of it, user might meet missing definition error at linking time.
- // Here we leave all CXXAddedFunctionDefinition unconditionally to avoid
- // potential issues.
- // TODO: Try to refine the strategy to handle CXXAddedFunctionDefinition
- // precisely.
+ // Move updates to DeclUpdatesLazy but leave the updates that may be needed by
+ // code generation eager.
----------------
ChuanqiXu9 wrote:
We need a FIXME here. The condition here is honestly ugly. We need better mechanism.
https://github.com/llvm/llvm-project/pull/235673
More information about the cfe-commits
mailing list