[clang-tools-extra] [llvm] [clangd] Move clang-tidy integration into a FeatureModule (PR #236054)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Oct 31 05:26:30 PDT 2026
================
@@ -297,7 +300,16 @@ class Checker {
// step-function slowdowns due to CPU scaling.
// We take the median of 5 measurements, and after every check discard the
// measurement if the baseline changed by >3%.
- void checkTidyTimes() {
+ bool checkTidyTimes() {
+ // Keep all other modules active while varying only tidy's configuration.
+ auto *TidyModule =
+ Inputs.FeatureModules
+ ? Inputs.FeatureModules->get<ClangTidyFeatureModule>()
----------------
JVApen wrote:
I'm a bit worried when I see this kind of construct. For me, this indicates that the module-abstraction isn't correctly working as you still need to know some specific implementation to get this working.
Not saying this needs to be solved now, though what would be required to prevent this? Does the module need an extra call, does data need to flow differently...?
Can you give some insights?
https://github.com/llvm/llvm-project/pull/236054
More information about the cfe-commits
mailing list