[clang] [compiler-rt] [libcxx] Implement soft x87 `long double` for ARM64EC (PR #236406)
Martin Storsjö via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 28 06:30:05 PDT 2026
mstorsjo wrote:
> > As there are commits for various subprojects (clang, libcxx, compiler-rt), those at least should be handled separately IMO. There are usually different people with authority to approve things for each of them, so handling it all in one megacommit is usually impractical. The changes for the runtimes need to be made so that they work both with the older and newer compiler anyway (while one can hold off of merging them until the compiler parts are complete). I didn't check the actual core clang changes if they can be split up functionally into smaller steps or not. If somehow possible to split them up into smaller atomic steps, that makes it much more feasible to actually get things approved and merged.
>
> Would you like these changes to be split in that way? What's the specific order that these should be filed?
I would go with the compiler changes first - changes to runtimes are secondary.
For the compiler-rt change, I'm unsure if that works for the current setup of llvm-mingw though. Since https://github.com/mstorsjo/llvm-mingw/commit/986847858c5d598682bedef87987290c8754d7ad we don't build compiler-rt twice for aarch64 and arm64ec, but just once for aarch64 with the `-marm64x` flag. So it runs the cmake configuration just once and builds the objects once. Internally, for each object file, clang then compiles it twice, for aarch64 and arm64ec. So for this case, the new file would need to be added for aarch64 too (but only for Windows targets), but the file can have internal ifdefs to make it an empty no-op for regular aarch64.
The changes to libcxx are even further down on the priority list; there's no instance that runs the libcxx tests in arm64ec mode at all right now, neither upstream nor downstream, as far as I know of.
https://github.com/llvm/llvm-project/pull/236406
More information about the cfe-commits
mailing list