[clang] [clang-repl] Link HIP device object into an HSACO (PR #235614)

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 26 08:01:08 PDT 2026


================
@@ -144,6 +146,13 @@ TEST(DeviceOffloadBuilderTest, MultipleOffloadArchsAreRejected) {
 }
 
 TEST_F(DeviceOffloadHIPTest, DeviceObjectIsGenerated) {
+  // The device object is linked into an HSACO with ld.lld.
+  std::string Exe = llvm::sys::fs::getMainExecutable(nullptr, nullptr);
+  if (!llvm::sys::findProgramByName("ld.lld",
+                                    {llvm::sys::path::parent_path(Exe)}) &&
+      !llvm::sys::findProgramByName("ld.lld"))
+    GTEST_SKIP() << "ld.lld not found";
----------------
yxsamliu wrote:

Could we keep the object-generation test running without `ld.lld` and test the HSACO link separately? Skipping this whole test also removes the existing object check.

https://github.com/llvm/llvm-project/pull/235614


More information about the cfe-commits mailing list