https://github.com/tarunprabhu commented: Overall, this looks reasonable, barring a couple of quick observations. I will be on travel most of next week, so I may not be able to take a second look at this until late in the week. https://github.com/llvm/llvm-project/pull/235101