[clang] [Clang]Preserve array information when reconstructing LValues (#223064) (PR #230599)

[Aditya Roy Chowdhury via cfe-commits]

================
@@ -209,10 +208,6 @@ namespace {
         ArraySize = 0;
         MostDerivedLength = I + 1;
         IsArray = false;
-      } else {
-        // Path[I] describes a base class.
----------------
adiroy28852 wrote:

Thanks for pointing this out. I kept the base-class branch and added a comment explaining why entering a base subobject preserves the most-derived object’s array information. I also added the p - p regression, plus coverage for an indirect non-first base and out-of-bounds access. Kindly check if it looks good. 

https://github.com/llvm/llvm-project/pull/230599