[clang] [CIR][SPIR-V] Use the program address space for global ctors and dtors (PR #233927)
Arseniy Obolenskiy via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 20 10:47:37 PDT 2026
https://github.com/aobolensk created https://github.com/llvm/llvm-project/pull/233927
llvm.global_ctors and llvm.global_dtors entries used addrspace(0) pointers, which asserted on targets with a non-zero program address space
>From 86ff1df700687925835eecb8d0ea542e623c45f9 Mon Sep 17 00:00:00 2001
From: Arseniy Obolenskiy <arseniy.obolenskiy at amd.com>
Date: Tue, 20 Oct 2026 19:46:02 +0200
Subject: [PATCH] [CIR][SPIR-V] Use the program address space for global ctors
and dtors
llvm.global_ctors and llvm.global_dtors entries used addrspace(0) pointers, which asserted on targets with a non-zero program address space
---
.../CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp | 4 +++-
clang/test/CIR/CodeGen/global-ctor-dtor.cpp | 16 ++++++++++++++++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
index ac005a4e838d10..a0761bd360f685 100644
--- a/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
+++ b/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp
@@ -4409,7 +4409,9 @@ static void buildCtorDtorList(
// Create a global array llvm.global_ctors with element type of
// struct { i32, ptr, ptr }
- auto ctorPFTy = mlir::LLVM::LLVMPointerType::get(builder.getContext());
+ cir::CIRDataLayout cirDataLayout(module);
+ auto ctorPFTy = mlir::LLVM::LLVMPointerType::get(
+ builder.getContext(), cirDataLayout.getProgramAddressSpace());
llvm::SmallVector<mlir::Type> ctorStructFields;
ctorStructFields.push_back(builder.getI32Type());
ctorStructFields.push_back(ctorPFTy);
diff --git a/clang/test/CIR/CodeGen/global-ctor-dtor.cpp b/clang/test/CIR/CodeGen/global-ctor-dtor.cpp
index e58261ebf54469..4d51a5154035c2 100644
--- a/clang/test/CIR/CodeGen/global-ctor-dtor.cpp
+++ b/clang/test/CIR/CodeGen/global-ctor-dtor.cpp
@@ -6,6 +6,10 @@
// RUN: FileCheck --check-prefix=LLVM --input-file=%t-cir.ll %s
// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -emit-llvm %s -o %t.ll
// RUN: FileCheck --check-prefix=OGCG --input-file=%t.ll %s
+// RUN: %clang_cc1 -std=c++20 -triple spirv64-amd-amdhsa -fclangir -emit-llvm %s -o - | FileCheck %s --check-prefix=LLVM-AS4
+// RUN: %clang_cc1 -std=c++20 -triple spirv64-amd-amdhsa -emit-llvm %s -o - | FileCheck %s --check-prefix=OGCG-AS4
+// RUN: %clang_cc1 -std=c++20 -triple spirv64-intel -fclangir -emit-llvm %s -o - | FileCheck %s --check-prefix=LLVM-AS9
+// RUN: %clang_cc1 -std=c++20 -triple spirv64-intel -emit-llvm %s -o - | FileCheck %s --check-prefix=OGCG-AS9
extern int bar();
void foo(void) __attribute__((constructor));
@@ -43,3 +47,15 @@ void foo4(void) {
// OGCG: @llvm.global_ctors = appending global [2 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 65535, ptr @_Z3foov, ptr null }, { i32, ptr, ptr } { i32 777, ptr @_Z4foo2v, ptr null }]
// OGCG: @llvm.global_dtors = appending global [2 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 65535, ptr @_Z4foo3v, ptr null }, { i32, ptr, ptr } { i32 789, ptr @_Z4foo4v, ptr null }]
+
+// LLVM-AS4: @llvm.global_ctors = appending global [2 x { i32, ptr addrspace(4), ptr addrspace(4) }] [{ i32, ptr addrspace(4), ptr addrspace(4) } { i32 65535, ptr addrspace(4) @_Z3foov, ptr addrspace(4) null }, { i32, ptr addrspace(4), ptr addrspace(4) } { i32 777, ptr addrspace(4) @_Z4foo2v, ptr addrspace(4) null }]
+// LLVM-AS4: @llvm.global_dtors = appending global [2 x { i32, ptr addrspace(4), ptr addrspace(4) }] [{ i32, ptr addrspace(4), ptr addrspace(4) } { i32 65535, ptr addrspace(4) @_Z4foo3v, ptr addrspace(4) null }, { i32, ptr addrspace(4), ptr addrspace(4) } { i32 789, ptr addrspace(4) @_Z4foo4v, ptr addrspace(4) null }]
+
+// OGCG-AS4: @llvm.global_ctors = appending addrspace(1) global [2 x { i32, ptr addrspace(4), ptr addrspace(4) }] [{ i32, ptr addrspace(4), ptr addrspace(4) } { i32 65535, ptr addrspace(4) @_Z3foov, ptr addrspace(4) null }, { i32, ptr addrspace(4), ptr addrspace(4) } { i32 777, ptr addrspace(4) @_Z4foo2v, ptr addrspace(4) null }]
+// OGCG-AS4: @llvm.global_dtors = appending addrspace(1) global [2 x { i32, ptr addrspace(4), ptr addrspace(4) }] [{ i32, ptr addrspace(4), ptr addrspace(4) } { i32 65535, ptr addrspace(4) @_Z4foo3v, ptr addrspace(4) null }, { i32, ptr addrspace(4), ptr addrspace(4) } { i32 789, ptr addrspace(4) @_Z4foo4v, ptr addrspace(4) null }]
+
+// LLVM-AS9: @llvm.global_ctors = appending global [2 x { i32, ptr addrspace(9), ptr addrspace(9) }] [{ i32, ptr addrspace(9), ptr addrspace(9) } { i32 65535, ptr addrspace(9) @_Z3foov, ptr addrspace(9) null }, { i32, ptr addrspace(9), ptr addrspace(9) } { i32 777, ptr addrspace(9) @_Z4foo2v, ptr addrspace(9) null }]
+// LLVM-AS9: @llvm.global_dtors = appending global [2 x { i32, ptr addrspace(9), ptr addrspace(9) }] [{ i32, ptr addrspace(9), ptr addrspace(9) } { i32 65535, ptr addrspace(9) @_Z4foo3v, ptr addrspace(9) null }, { i32, ptr addrspace(9), ptr addrspace(9) } { i32 789, ptr addrspace(9) @_Z4foo4v, ptr addrspace(9) null }]
+
+// OGCG-AS9: @llvm.global_ctors = appending addrspace(1) global [2 x { i32, ptr addrspace(9), ptr addrspace(9) }] [{ i32, ptr addrspace(9), ptr addrspace(9) } { i32 65535, ptr addrspace(9) @_Z3foov, ptr addrspace(9) null }, { i32, ptr addrspace(9), ptr addrspace(9) } { i32 777, ptr addrspace(9) @_Z4foo2v, ptr addrspace(9) null }]
+// OGCG-AS9: @llvm.global_dtors = appending addrspace(1) global [2 x { i32, ptr addrspace(9), ptr addrspace(9) }] [{ i32, ptr addrspace(9), ptr addrspace(9) } { i32 65535, ptr addrspace(9) @_Z4foo3v, ptr addrspace(9) null }, { i32, ptr addrspace(9), ptr addrspace(9) } { i32 789, ptr addrspace(9) @_Z4foo4v, ptr addrspace(9) null }]
More information about the cfe-commits
mailing list