[clang] [CIR] Implement support for MatrixSingleSubscript expr (PR #232079)

Amr Hesham via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 17 07:57:31 PDT 2026


================
@@ -73,7 +73,7 @@ mlir::Attribute getBitIntStorageAttr(mlir::ConversionPatternRewriter &rewriter,
 
 mlir::Type convertTypeForMemory(const mlir::TypeConverter &converter,
                                 mlir::DataLayout const &dataLayout,
-                                mlir::Type type) {
+                                mlir::Type type, bool isForHLSL) {
----------------
AmrDeveloper wrote:

I am thinking: can't we just use `LoweringLangOptionsAttr` directly? It's one per module, we can access it from any Operation. There are already functions to access ops, for example, `getHLSL` without the need to introduce another layer/wrapper around it 🤔.

https://github.com/llvm/llvm-project/pull/232079


More information about the cfe-commits mailing list