[clang] [CIR] Implement support for MatrixSingleSubstract expr (PR #232079)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 13:46:19 PDT 2026


================
@@ -73,7 +73,7 @@ mlir::Attribute getBitIntStorageAttr(mlir::ConversionPatternRewriter &rewriter,
 
 mlir::Type convertTypeForMemory(const mlir::TypeConverter &converter,
                                 mlir::DataLayout const &dataLayout,
-                                mlir::Type type) {
+                                mlir::Type type, bool isForHLSL) {
----------------
erichkeane wrote:

oh, i see now... I dont' like having our helpers have the lang-opts so willy-nilly encoded. I'd suggest we move the list of options/module attribute facts/etc to be owned by someone that we can all just 'check' instead.

https://github.com/llvm/llvm-project/pull/232079


More information about the cfe-commits mailing list