[clang] [clang-repl] Add OffloadType enum and HIP device parser skeleton (PR #231391)
Aditya Sinha via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 14 02:38:58 PDT 2026
================
@@ -479,6 +479,18 @@ llvm::Expected<std::unique_ptr<Interpreter>> Interpreter::create(
llvm::Expected<std::unique_ptr<Interpreter>>
Interpreter::createWithCUDA(std::unique_ptr<CompilerInstance> CI,
std::unique_ptr<CompilerInstance> DCI) {
+ return createWithDevice(std::move(CI), std::move(DCI), OffloadType::CUDA);
+}
+
+llvm::Expected<std::unique_ptr<Interpreter>>
+Interpreter::createWithDevice(std::unique_ptr<CompilerInstance> CI,
----------------
AdityaSinha149 wrote:
> Could you add tests for the `Detect` error and the HIP unsupported error? These paths have no regression coverage yet, and they can be tested without running a GPU kernel.
I have created a PR for adding the hip option #231783. I have also created the hip unsupported error test there. That PR is dependent on this PR, Can we merge this PR first if everything else is fine? and then go to that PR and add tests.
https://github.com/llvm/llvm-project/pull/231391
More information about the cfe-commits
mailing list