[clang] [CIR][SPIR-V] Keep atomic sync scopes (PR #231754)

Steffen Larsen via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 14 00:30:58 PDT 2026


================
@@ -27,7 +27,12 @@ constexpr unsigned SPIRVAddrSpaceMap[] = {
 };
 
 class SPIRVTargetLoweringInfo : public TargetLoweringInfo {
+  // SPIR keeps the default system scope, like CommonSPIRTargetCodeGenInfo.
+  bool isSPIRV;
----------------
steffenlarsen wrote:

Reads a little weird that something called `SPIRVTargetLoweringInfo` is not SPIR-V. Would it make sense to invert the bool, i.e. make it `isSPIR`, or rename the `SPIRVTargetLoweringInfo` to `SPIRTargetLoweringInfo`?

Alternatively, should we consider splitting `SPIRVTargetLoweringInfo` into two, so `SPIR` gets it own and we either make `SPIRVTargetLoweringInfo` inherit from it or make a common base class and diverge the behavior only when required through overriding?

https://github.com/llvm/llvm-project/pull/231754


More information about the cfe-commits mailing list