[clang] [Clang] Fix crash on non-parameter NTTP arguments during partial ordering (PR #231599)

[Younan Zhang via cfe-commits]

================
@@ -257,9 +257,10 @@ getNTTParameterFromExpr(const Expr *E, UnsignedOrNone Depth) {
 }
 
 QualType Sema::getTypeOfConstantTemplateParameter(const TemplateArgument &Arg) {
-  if (NonTypeOrVarTemplateParmDecl NTTP =
-          getNTTParameterFromExpr(Arg.getAsExpr(), std::nullopt))
-    return NTTP.getType();
+  if (Arg.getKind() == TemplateArgument::Expression)
----------------
zyn0217 wrote:

+1 that check looks suspicious to me too

https://github.com/llvm/llvm-project/pull/231599