[clang] [llvm] [AArch64] Prevent hotpatching from intercepting loop backedges (PR #229477)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 12 12:48:22 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,c,cpp -- llvm/lib/Target/AArch64/AArch64HotpatchPadding.cpp clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/patchable-function-entry.c clang/test/DebugInfo/CXX/hotpatch-aarch64.cpp clang/test/DebugInfo/CXX/hotpatch-arm.cpp llvm/lib/CodeGen/PatchableFunction.cpp llvm/lib/Target/AArch64/AArch64.h llvm/lib/Target/AArch64/AArch64InstrInfo.cpp llvm/lib/Target/AArch64/AArch64TargetMachine.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/AArch64/AArch64HotpatchPadding.cpp b/llvm/lib/Target/AArch64/AArch64HotpatchPadding.cpp
index 1f4c9cbe6..67cc5eb2c 100644
--- a/llvm/lib/Target/AArch64/AArch64HotpatchPadding.cpp
+++ b/llvm/lib/Target/AArch64/AArch64HotpatchPadding.cpp
@@ -11,8 +11,8 @@
// but an entry block that emits no code lets a branch to the next block (e.g. a
// loop backedge) target the function's first instruction, which a hotpatch
// overwrites. Such entry blocks are padded with a NOP, placed after any
-// zero-byte instructions (e.g. an empty Windows prologue). Like on x86, an entry
-// that starts with inline assembly is also padded, since the assembly may
+// zero-byte instructions (e.g. an empty Windows prologue). Like on x86, an
+// entry that starts with inline assembly is also padded, since the assembly may
// define a branch target.
//
// This must run after every pass that may delete instructions, and before
``````````
</details>
https://github.com/llvm/llvm-project/pull/229477
More information about the cfe-commits
mailing list