[clang] [NFC][analyzer] Remove guaranteedNotToCloseFile from SimpleStreamChecker (PR #230288)

[Donát Nagy via cfe-commits]

================
@@ -218,7 +201,7 @@ SimpleStreamChecker::checkPointerEscape(ProgramStateRef State,
                                         const CallEvent *Call,
                                         PointerEscapeKind Kind) const {
   // If we know that the call cannot close a file, there is nothing to do.
-  if (Kind == PSK_DirectEscapeOnCall && guaranteedNotToCloseFile(*Call)) {
+  if (Kind == PSK_DirectEscapeOnCall && Call->isInSystemHeader()) {
----------------
NagyDonat wrote:

Thanks for dropping this inline comment, things like this are really helpful for a reviewer :smile:!

https://github.com/llvm/llvm-project/pull/230288