[clang] [clang][AST] Fix crash on labeled break/continue within switch condition statement expression (PR #228655)

[Oliver Hunt via cfe-commits]

ojhunt wrote:

> > > > That said, a mismatch in diagnostics between the old evaluator and new interpreter happens sometimes and isn’t necessarily a bug
> > > 
> > > 
> > > Alright then, I've adjusted the tests such that they pass regardless of whether the note diagnostic is seen.
> > 
> > 
> > you can use `--check-prefixes` (or something similar) to handle the diagnostic differences between runs. The change you've got allows the test to silently regress.
> 
> Interesting. That's a FileCheck option though?
> 
> I've looked at the docs and found that cc1's `-verify` option accepts an argument to select prefixes besides `expected-`, similar to FileCheck's `--check-prefixes`. The tests have been updated accordingly, to remove the possibility of regression which you've highlighted.

yeah despite many many years my memory refuses to remember it's just additional arguments to verify :D

https://github.com/llvm/llvm-project/pull/228655