[clang-tools-extra] [clangd] Make the --skip-preamble-build option take an enum (PR #229515)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 6 11:52:03 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clangd/ClangdServer.h clang-tools-extra/clangd/tool/ClangdMain.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang-tools-extra/clangd/ClangdServer.cpp b/clang-tools-extra/clangd/ClangdServer.cpp
index 3d3a851ef..0c4653ee8 100644
--- a/clang-tools-extra/clangd/ClangdServer.cpp
+++ b/clang-tools-extra/clangd/ClangdServer.cpp
@@ -1221,13 +1221,16 @@ void ClangdServer::adjustParseInputs(ParseInputs &Inputs, PathRef File) const {
return ModulesManager->hasRequiredModules(File);
};
- Inputs.Opts.SkipPreambleBuild = [&](){
- switch(SkipPreambleBuild){
+ Inputs.Opts.SkipPreambleBuild = [&]() {
+ switch (SkipPreambleBuild) {
using enum SkipPreambleBuildPolicy;
- case Never: return false;
- case Modules: return HasRequiredModules();
- case Always: return true;
+ case Never:
+ return false;
+ case Modules:
+ return HasRequiredModules();
+ case Always:
+ return true;
}
}();
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/229515
More information about the cfe-commits
mailing list