[libclc] libclc: Stop requiring SPV_KHR_fma (PR #226186)
Karol Herbst via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 6 05:14:06 PDT 2026
https://github.com/karolherbst updated https://github.com/llvm/llvm-project/pull/226186
>From 4909ace06215ec7591313118cf5537cc137582ec Mon Sep 17 00:00:00 2001
From: Karol Herbst <kherbst at redhat.com>
Date: Thu, 24 Sep 2026 16:49:38 +0200
Subject: [PATCH] libclc: Stop requiring SPV_KHR_fma
SPV_KHR_fma and the OpenCL Extended Instruction fma are equivalent. The
latter however is required to be supported by OpenCL runtimes where the
former is not.
Let's remove this requirement, because it adds no value and only makes it
more difficult to consume a SPIR-V that uses optional features.
---
libclc/cmake/modules/AddLibclc.cmake | 2 --
1 file changed, 2 deletions(-)
diff --git a/libclc/cmake/modules/AddLibclc.cmake b/libclc/cmake/modules/AddLibclc.cmake
index d84101f71d2f9..29bc93b5515eb 100644
--- a/libclc/cmake/modules/AddLibclc.cmake
+++ b/libclc/cmake/modules/AddLibclc.cmake
@@ -165,7 +165,6 @@ function(libclc_add_library target_name)
if(LIBCLC_USE_SPIRV_BACKEND)
add_custom_command(OUTPUT ${builtins_lib}
COMMAND ${CMAKE_CLC_COMPILER} -c --target=${ARG_TRIPLE}
- -mllvm --spirv-ext=+SPV_KHR_fma
-x ir -o ${builtins_lib} ${linked_bc}
DEPENDS ${linked_bc}
)
@@ -173,7 +172,6 @@ function(libclc_add_library target_name)
add_custom_command(OUTPUT ${builtins_lib}
COMMAND ${llvm-spirv_exe}
--spirv-max-version=1.1
- --spirv-ext=+SPV_KHR_fma
-o ${builtins_lib} ${linked_bc}
DEPENDS ${linked_bc}
)
More information about the cfe-commits
mailing list