[clang] [libclang/python] Fold CCRStructure into CodeCompletionResults (PR #224678)

Vlad Serebrennikov via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 6 01:15:06 PDT 2026


================
@@ -3216,38 +3216,20 @@ def __getitem__(self, key: int) -> CodeCompletionResult:
         return self.results[key]
 
 
-class CodeCompletionResults(ClangObject):
-    def __init__(self, ptr: _Pointer[CCRStructure]):
-        assert isinstance(ptr, POINTER(CCRStructure)) and ptr
-        self.ptr = self._as_parameter_ = ptr
----------------
Endilll wrote:

My guess is that `CodeCompletionResults` was there to hold what `clang_codeCompleteAt` returns, which was `POINTER(CCRStructure)`, and provide convenience functions over it. I think I understand what was going on, but I don't fully understand what is not clear to you to explain that, so if you give me a couple of more targeted questions, I'll try to clear the confusion.

https://github.com/llvm/llvm-project/pull/224678


More information about the cfe-commits mailing list