[clang-tools-extra] [clang-tidy][NFC] Move isOutOfLine matcher into utils::Matchers (PR #228547)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/obj.clangTidyModernizeModule.dir/UseEqualsDefaultCheck.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/obj.clangTidyModernizeModule.dir/UseEqualsDefaultCheck.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\clang-tidy\modernize -IC:\_work\llvm-project\llvm-project\clang-tools-extra\clang-tidy\modernize -IC:\_work\llvm-project\llvm-project\build\tools\clang\tools\extra\clang-tidy -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvc"C:\BuildTools\DIA SDK\include" /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /Brepro /EHs-c- /GR- /showIncludes /Fotools\clang\tools\extra\clang-tidy\modernize\CMakeFiles\obj.clangTidyModernizeModule.dir\UseEqualsDefaultCheck.cpp.obj /Fdtools\clang\tools\extra\clang-tidy\modernize\CMakeFiles\obj.clangTidyModernizeModule.dir\ -c -- C:\_work\llvm-project\llvm-project\clang-tools-extra\clang-tidy\modernize\UseEqualsDefaultCheck.cpp
C:\_work\llvm-project\llvm-project\clang-tools-extra\clang-tidy\modernize\UseEqualsDefaultCheck.cpp(53,8): error: reference to 'internal' is ambiguous
53 | static internal::Matcher<Expr> accessToFieldInVar(const FieldDecl *Field,
|        ^
C:\_work\llvm-project\llvm-project\clang\include\clang/ASTMatchers/ASTMatchFinder.h(293,11): note: candidate found by name lookup is 'clang::ast_matchers::internal'
293 | namespace internal {
|           ^
C:\_work\llvm-project\llvm-project\clang-tools-extra\clang-tidy\modernize\../utils/Matchers.h(165,1): note: candidate found by name lookup is 'clang::tidy::matchers::internal'
165 | AST_MATCHER_P(Stmt, isStatementIdenticalToBoundNode, std::string, ID) {
| ^
C:\_work\llvm-project\llvm-project\clang\include\clang/ASTMatchers/ASTMatchersMacros.h(131,3): note: expanded from macro 'AST_MATCHER_P'
131 |   AST_MATCHER_P_OVERLOAD(Type, DefineMatcher, ParamType, Param, 0)
|   ^
C:\_work\llvm-project\llvm-project\clang\include\clang/ASTMatchers/ASTMatchersMacros.h(135,13): note: expanded from macro 'AST_MATCHER_P_OVERLOAD'
135 |   namespace internal {                                                         \
|             ^
C:\_work\llvm-project\llvm-project\clang-tools-extra\clang-tidy\modernize\UseEqualsDefaultCheck.cpp(55,10): error: no viable conversion from returned value of type '::clang::ast_matchers::internal::Matcher<Expr>' to function return type 'int'
55 |   return ignoringImpCasts(
|          ^~~~~~~~~~~~~~~~~
56 |       memberExpr(hasObjectExpression(declRefExpr(to(varDecl(equalsNode(Var))))),
|       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
57 |                  member(fieldDecl(equalsNode(Field)))));
|                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\clang\include\clang/ASTMatchers/ASTMatchersInternal.h(624,3): note: candidate function
624 |   operator DynTypedMatcher() const & { return Implementation; }
|   ^
C:\_work\llvm-project\llvm-project\clang\include\clang/ASTMatchers/ASTMatchersInternal.h(626,3): note: candidate function
626 |   operator DynTypedMatcher() && { return std::move(Implementation); }
|   ^
2 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/228547