[clang] ea458d2 - [CIR][AMDGPU] Drop stale logb FIXME in amdgcnspirv-builtins.hip (NFC) (#228404)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 2 05:34:36 PDT 2026
Author: Arseniy Obolenskiy
Date: 2026-10-02T12:34:19Z
New Revision: ea458d215c1e24654429e91f0d16100e7bf6c643
URL: https://github.com/llvm/llvm-project/commit/ea458d215c1e24654429e91f0d16100e7bf6c643
DIFF: https://github.com/llvm/llvm-project/commit/ea458d215c1e24654429e91f0d16100e7bf6c643.diff
LOG: [CIR][AMDGPU] Drop stale logb FIXME in amdgcnspirv-builtins.hip (NFC) (#228404)
#228004 made CIR emit nsw add and ordered compare for logb, so update
the SPIR-V checks to match
Fix failure appeared on main branch
Added:
Modified:
clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip
Removed:
################################################################################
diff --git a/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip b/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip
index 015d4e57a2e29..dd92cfab285f1 100644
--- a/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip
+++ b/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip
@@ -76,13 +76,11 @@ __device__ float test_logb(float x) {
// CIR-LABEL: cir.func no_inline @_Z9test_logbf
// CIR: cir.call_llvm_intrinsic "frexp" %{{.*}} : (!cir.float) -> !rec_anon_struct
-// FIXME: CIR emits 'add' without 'nsw' and 'fcmp une' instead of 'fcmp one'.
-
// LLVM-LABEL: define spir_func noundef float @_Z9test_logbf
// LLVM: call{{.*}} @llvm.frexp.f32.i32
-// LLVM: add i32 %{{.*}}, -1
+// LLVM: add nsw i32 %{{.*}}, -1
// LLVM: call addrspace(4) float @llvm.fabs.f32
-// LLVM: fcmp une float %{{.*}}, +inf
+// LLVM: fcmp one float %{{.*}}, +inf
// OGCG-LABEL: define spir_func noundef float @_Z9test_logbf
// OGCG: call{{.*}} @llvm.frexp.f32.i32
More information about the cfe-commits
mailing list