[clang] [CIR][AMDGPU] Drop stale logb FIXME in amdgcnspirv-builtins.hip (NFC) (PR #228404)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 2 04:43:17 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Arseniy Obolenskiy (aobolensk)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/228404.diff
1 Files Affected:
- (modified) clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip (+2-4)
``````````diff
diff --git a/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip b/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip
index 015d4e57a2e29..dd92cfab285f1 100644
--- a/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip
+++ b/clang/test/CIR/CodeGenHIP/amdgcnspirv-builtins.hip
@@ -76,13 +76,11 @@ __device__ float test_logb(float x) {
// CIR-LABEL: cir.func no_inline @_Z9test_logbf
// CIR: cir.call_llvm_intrinsic "frexp" %{{.*}} : (!cir.float) -> !rec_anon_struct
-// FIXME: CIR emits 'add' without 'nsw' and 'fcmp une' instead of 'fcmp one'.
-
// LLVM-LABEL: define spir_func noundef float @_Z9test_logbf
// LLVM: call{{.*}} @llvm.frexp.f32.i32
-// LLVM: add i32 %{{.*}}, -1
+// LLVM: add nsw i32 %{{.*}}, -1
// LLVM: call addrspace(4) float @llvm.fabs.f32
-// LLVM: fcmp une float %{{.*}}, +inf
+// LLVM: fcmp one float %{{.*}}, +inf
// OGCG-LABEL: define spir_func noundef float @_Z9test_logbf
// OGCG: call{{.*}} @llvm.frexp.f32.i32
``````````
</details>
https://github.com/llvm/llvm-project/pull/228404
More information about the cfe-commits
mailing list