https://github.com/AaronBallman commented: Generally is looking good to me, though I think there are some additional tests to add. @erichkeane how are you feeling about the current shape of things? https://github.com/llvm/llvm-project/pull/220259