[clang] [clang-repl] Don't check printf output order in pretty-print.cpp (PR #228349)

Jonas Rembser via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 2 00:51:43 PDT 2026


https://github.com/guitargeek updated https://github.com/llvm/llvm-project/pull/228349

>From cdd04665aba7e03def7917820ad66c3f3457ed18 Mon Sep 17 00:00:00 2001
From: Jonas Rembser <jonas.rembser at cern.ch>
Date: Fri, 2 Oct 2026 07:04:01 +0000
Subject: [PATCH] [clang-repl] Don't check printf output order in
 pretty-print.cpp

The test added in #228334 checked the output of a JIT'd printf() with
CHECK-NEXT between lines that clang-repl prints itself. The C runtime
buffers the JIT'd code's stdout separately, so the order is not
guaranteed: on llvm-clang-x86_64-sie-win, "foo()" came after all of
clang-repl's output.

Remove that case. The case before it already checks that a void call
without a semicolon is executed (through the value of a variable it
sets), and so does the unit test ValueOfVoidCallExecutesTheCall.

Assisted-by: Claude Opus 5.5
---
 clang/test/Interpreter/pretty-print.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/clang/test/Interpreter/pretty-print.cpp b/clang/test/Interpreter/pretty-print.cpp
index ed430d2db6d224..777d809873203a 100644
--- a/clang/test/Interpreter/pretty-print.cpp
+++ b/clang/test/Interpreter/pretty-print.cpp
@@ -96,9 +96,6 @@ void set_void_x() { void_x = 100; }
 set_void_x()
 void_x
 // CHECK-NEXT: (int) 100
-void print_foo() { printf("foo()\n"); }
-print_foo()
-// CHECK-NEXT: foo()
 
 // int i = 12;
 // int &iref = i;



More information about the cfe-commits mailing list