[clang] [llvm] [RISC-V][RVY] Fix round-trip and order of arch strings with 'y' (PR #227865)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 1 00:06:53 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c -- clang/test/Driver/print-supported-extensions-riscv.c llvm/lib/Support/RISCVISAUtils.cpp llvm/lib/TargetParser/RISCVISAInfo.cpp llvm/unittests/TargetParser/RISCVISAInfoTest.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp b/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
index 1ac95e241..6f4d171f2 100644
--- a/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
+++ b/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
@@ -214,9 +214,9 @@ TEST(ParseArchString, RejectsInvalidBaseISA) {
TEST(ParseArchString, RejectsInvalidYPosition) {
// 'y' is only allowed as a singular base ISA ('rv32y'/'rv64y') or immediately
// after 'i' or 'e' ('rv32iy'/'rv32ey'). Anything else should be rejected.
- for (StringRef Input : {"rv32gy0p910", "rv64gy0p910", "rv32imy0p910",
- "rv64imy0p910", "rv32i_m_y0p910", "rv64y0p910_y0p910",
- "rv64iy0p910_y0p910"}) {
+ for (StringRef Input :
+ {"rv32gy0p910", "rv64gy0p910", "rv32imy0p910", "rv64imy0p910",
+ "rv32i_m_y0p910", "rv64y0p910_y0p910", "rv64iy0p910_y0p910"}) {
EXPECT_EQ(toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
"invalid standard user-level extension 'y'");
}
@@ -251,7 +251,8 @@ TEST(ParseArchString, AcceptsRVYBaseISA) {
const auto &ExtsRV32EY = InfoRV32EY.getExtensions();
EXPECT_EQ(ExtsRV32EY.size(), 2UL); // e, y
EXPECT_TRUE(ExtsRV32EY.at("e") == (RISCVISAUtils::ExtensionVersion{2, 0}));
- EXPECT_TRUE(ExtsRV32EY.at("y") == (RISCVISAUtils::ExtensionVersion{0, 910}));
+ EXPECT_TRUE(ExtsRV32EY.at("y") ==
+ (RISCVISAUtils::ExtensionVersion{0, 910}));
EXPECT_EQ(InfoRV32EY.getXLen(), 32U);
EXPECT_EQ(InfoRV32EY.toString(), "rv32e2p0_y0p910");
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/227865
More information about the cfe-commits
mailing list