[clang] [clang] Consistently cache failed constraint normalization (PR #227086)

[via cfe-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Sema/SemaConcept.cpp clang/test/CXX/temp/temp.constr/temp.constr.normal/p1.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaConcept.cpp b/clang/lib/Sema/SemaConcept.cpp
index a111fc803..da5e6f3f4 100644
--- a/clang/lib/Sema/SemaConcept.cpp
+++ b/clang/lib/Sema/SemaConcept.cpp
@@ -2533,7 +2533,8 @@ const NormalizedConstraint *Sema::getNormalizedAssociatedConstraints(
     auto *Normalized = NormalizedConstraint::fromAssociatedConstraints(
         *this, ND, AssociatedConstraints);
     // substitute() can invalidate iterators of NormalizationCache.
-    if (Normalized && SubstituteParameterMappings(*this).substitute(*Normalized))
+    if (Normalized &&
+        SubstituteParameterMappings(*this).substitute(*Normalized))
       Normalized = nullptr;
     CacheEntry =
         NormalizationCache.try_emplace(ConstrainedDeclOrNestedReq, Normalized)

``````````

</details>


https://github.com/llvm/llvm-project/pull/227086