[clang] [Sema] Return RecoveryExpr for ARC atomic ownership error (PR #224849)

via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 27 10:51:56 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Sema/SemaChecking.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Basic/DiagnosticIDs.cpp b/clang/lib/Basic/DiagnosticIDs.cpp
index ee0287e0c..efc934614 100644
--- a/clang/lib/Basic/DiagnosticIDs.cpp
+++ b/clang/lib/Basic/DiagnosticIDs.cpp
@@ -961,7 +961,8 @@ bool DiagnosticIDs::isUnrecoverable(unsigned DiagID) const {
   // because sending a message with an unknown selector could lead to crashes
   // within CodeGen if the resulting expression is used to initialize a C++
   // auto variable, where type deduction is required.
-  if (isARCDiagnostic(DiagID) && DiagID != diag::err_arc_may_not_respond && DiagID != diag::err_arc_atomic_ownership)
+  if (isARCDiagnostic(DiagID) && DiagID != diag::err_arc_may_not_respond &&
+      DiagID != diag::err_arc_atomic_ownership)
     return false;
 
   if (isCodegenABICheckDiagnostic(DiagID))
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 2aca4e8b3..104e9d688 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -5752,7 +5752,7 @@ ExprResult Sema::BuiltinAtomicOverloaded(ExprResult TheCallResult) {
     Diag(DRE->getBeginLoc(), diag::err_arc_atomic_ownership)
         << ValType << FirstArg->getSourceRange();
 
-		return ExprError();
+    return ExprError();
   }
 
   // Strip any qualifiers off ValType.

``````````

</details>


https://github.com/llvm/llvm-project/pull/224849


More information about the cfe-commits mailing list