[clang] [Sema] Return RecoveryExpr for ARC atomic ownership error (PR #224849)

[Demetrios Chiuratto Agourakis via cfe-commits]

agourakis82 wrote:

Thanks for the fix! One question: the test expects a second diagnostic, "cannot compile this scalar expression yet", which comes from CodeGen. Doesn't that mean the RecoveryExpr still reaches CodeGen after the Sema error? I'd have expected CodeGen not to run at all here. Would a `-fsyntax-only` test in SemaObjC (plus checking that no CodeGen diagnostic is emitted) be a better fit?

https://github.com/llvm/llvm-project/pull/224849