[clang] Revert "[clang][bytecode] Stop relying on `CheckEvaluationResult()` (… (PR #226637)

[via cfe-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Timm Baeder (tbaederr)

<details>
<summary>Changes</summary>

…#<!-- -->186045)"

This reverts commit 55b498466a7b2620d09fcdf1b2300f71a35f6d8b.

This breaks two msan builders and reproducing the failure locally takes forever.

---
Full diff: https://github.com/llvm/llvm-project/pull/226637.diff


20 Files Affected:

- (modified) clang/lib/AST/ByteCode/ByteCodeEmitter.h (-1) 
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (-6) 
- (modified) clang/lib/AST/ByteCode/Context.cpp (+4-3) 
- (modified) clang/lib/AST/ByteCode/Disasm.cpp (+4-1) 
- (modified) clang/lib/AST/ByteCode/EvalEmitter.cpp (+24-46) 
- (modified) clang/lib/AST/ByteCode/EvalEmitter.h (+3-14) 
- (modified) clang/lib/AST/ByteCode/EvaluationResult.cpp (+1-381) 
- (modified) clang/lib/AST/ByteCode/EvaluationResult.h (+10-22) 
- (modified) clang/lib/AST/ByteCode/Interp.cpp (+1-3) 
- (modified) clang/lib/AST/ByteCode/InterpBuiltinObjectSize.cpp (+1-1) 
- (modified) clang/lib/AST/ByteCode/Pointer.cpp (+1-5) 
- (modified) clang/lib/AST/ByteCode/Pointer.h (+3-8) 
- (modified) clang/lib/AST/ExprConstShared.h (-42) 
- (modified) clang/lib/AST/ExprConstant.cpp (+98-47) 
- (modified) clang/test/AST/ByteCode/builtin-functions.cpp (+3-3) 
- (modified) clang/test/AST/ByteCode/codegen-constexpr-unknown.cpp (-1) 
- (modified) clang/test/AST/ByteCode/references.cpp (+3-2) 
- (modified) clang/test/CodeGenCXX/global-init.cpp (-8) 
- (modified) clang/test/SemaCXX/PR19955.cpp (-3) 
- (modified) clang/test/SemaCXX/cxx2c-expansion-stmts.cpp (+2-2) 


``````````diff
The server is unavailable at this time. Please wait a few minutes before you try again.
``````````

</details>


https://github.com/llvm/llvm-project/pull/226637