[clang] [Clang][Lex] Implement CWG3013: Error if #embed parameters were defined as macros (PR #224769)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 21 22:15:46 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,c,h -- clang/test/CXX/drs/cwg3013.cpp clang/test/Preprocessor/embed_cxx_compat.c clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPDirectives.cpp clang/lib/Lex/Preprocessor.cpp clang/test/CXX/drs/cwg30xx.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Lex/PPDirectives.cpp b/clang/lib/Lex/PPDirectives.cpp
index bcf6a554b..35697284e 100644
--- a/clang/lib/Lex/PPDirectives.cpp
+++ b/clang/lib/Lex/PPDirectives.cpp
@@ -3771,8 +3771,8 @@ void Preprocessor::HandleElifFamilyDirective(Token &ElifToken,
std::optional<LexEmbedParametersResult>
Preprocessor::LexEmbedParameters(Token &CurTok, bool ForHasEmbed) {
LexEmbedParametersResult Result{};
- assert(!ForHasEmbed || isParsingIfOrElifDirective() &&
- "__has_embed outside of #if or #elif directive?");
+ assert(!ForHasEmbed || isParsingIfOrElifDirective() &&
+ "__has_embed outside of #if or #elif directive?");
llvm::SaveAndRestore InEmbedParams(ParsingEmbedParameters, true);
tok::TokenKind EndTokenKind = ForHasEmbed ? tok::r_paren : tok::eod;
``````````
</details>
https://github.com/llvm/llvm-project/pull/224769
More information about the cfe-commits
mailing list