[clang] [CIR] Read a non-byval parameter back out of its spill slot (PR #225010)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 21 15:50:12 PDT 2026


================
@@ -1063,14 +1063,147 @@ void rewriteIndirectReturnCall(cir::CallOp call,
 
 } // namespace
 
-void CIRABIRewriteContext::normalizeParameterSlotAlignments(
+/// Bring \p funcOp's non-byval indirect parameter \p argNo into the shape the
+/// rest of the rewrite assumes.  \p claimedSlots carries the slots \p funcOp's
+/// earlier non-byval indirect parameters took.  See prepareNonByvalParameters.
----------------
andykaylor wrote:

It's not clear what this comment wants me to see `prepareNonByvalParameters` about. It even took me a second to see that the difference between that function name and the current function name was the trailing `s`.

https://github.com/llvm/llvm-project/pull/225010


More information about the cfe-commits mailing list