[clang] [clang-tools-extra] [Clang] Implement `__builtin_sort_pack` (PR #225025)

via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 21 01:09:55 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/test/SemaTemplate/sort-types-builtin.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang/lib/AST/DeclTemplate.cpp clang/lib/Sema/SemaTemplate.cpp clang/test/Import/builtin-template/Inputs/S.cpp clang/test/Import/builtin-template/test.cpp clang/test/PCH/dedup_types.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
index 9cae39965..be4044d85 100644
--- a/clang/lib/Sema/SemaTemplate.cpp
+++ b/clang/lib/Sema/SemaTemplate.cpp
@@ -3436,15 +3436,15 @@ static QualType sortBuiltinTemplatePack(ASTContext &Context,
   std::unique_ptr<MangleContext> MC(Context.createMangleContext());
   SmallVector<std::pair<std::string, TemplateArgument>> SortedArgs(
       InputArgs.size());
-  llvm::transform(
-      InputArgs, SortedArgs.begin(), [&](const TemplateArgument &Arg) {
-        assert(Arg.getKind() == TemplateArgument::Type);
-        std::string MangledName;
-        llvm::raw_string_ostream OS(MangledName);
-        MC->mangleCanonicalTypeName(Arg.getAsType(), OS);
-        return std::pair<std::string, TemplateArgument>(std::move(MangledName),
-                                                        Arg);
-      });
+  llvm::transform(InputArgs, SortedArgs.begin(),
+                  [&](const TemplateArgument &Arg) {
+                    assert(Arg.getKind() == TemplateArgument::Type);
+                    std::string MangledName;
+                    llvm::raw_string_ostream OS(MangledName);
+                    MC->mangleCanonicalTypeName(Arg.getAsType(), OS);
+                    return std::pair<std::string, TemplateArgument>(
+                        std::move(MangledName), Arg);
+                  });
   llvm::stable_sort(SortedArgs, llvm::less_first());
 
   auto OutArgs = llvm::to_vector(llvm::make_second_range(SortedArgs));

``````````

</details>


https://github.com/llvm/llvm-project/pull/225025


More information about the cfe-commits mailing list